UI: Fix task instance state badge staying stale after Mark-as action#67950
Merged
bbovenzi merged 1 commit intoJun 3, 2026
Merged
Conversation
GayathriSrividya
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
GayathriSrividya
force-pushed
the
fix/ui-ti-badge-stale-67883
branch
from
d20ce45 to
745d9e4
Compare
bbovenzi
approved these changes
Jun 3, 2026
Contributor
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker ed10d7b v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #67883
After marking a task instance as success/failed/skipped, the state badge
on the task instance detail page does not update until a manual page reload.
The root cause is in
usePatchTaskInstance: theGetMappedTaskInstancequery was invalidated using the full 4-field key
UseTaskInstanceServiceGetMappedTaskInstanceKeyFn({ dagId, dagRunId, mapIndex, taskId }).While this exact key should theoretically match, TanStack Query's
partialDeepEqualmatching is more reliable when the search key is asubset of the cached key rather than an exact match.
usePatchDagRunalready uses the partial-key pattern for the same query:This PR aligns
usePatchTaskInstanceto the same approach, using[useTaskInstanceServiceGetMappedTaskInstanceKey, { dagId, dagRunId, taskId }]as a partial key that matches any
mapIndexfor the given task. This alsoeliminates the separate predicate-based invalidation that was needed for the
"patch all mapped TIs" case (
mapIndex === undefined), simplifying the code.